innocuous-symmetry/core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Pass a helpful name when creating common asyncio tasks in core (#89171)

Browse Source
This commit is contained in:
J. Nick Koston
2023-03-05 01:46:02 -10:00
committed by GitHub
parent 927b43626c
commit 11681f3f31
23 changed files with 169 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
homeassistant/config_entries.py
View File

@@ -729,7 +729,8 @@ class ConfigEntry:
}
| (context or {}),
data=self.data | (data or {}),
)
),
f"config entry reauth {self.title} {self.domain} {self.entry_id}",
)
@callback
@@ -746,7 +747,10 @@ class ConfigEntry:
@callback
def async_create_task(
self, hass: HomeAssistant, target: Coroutine[Any, Any, _R]
self,
hass: HomeAssistant,
target: Coroutine[Any, Any, _R],
name: str | None = None,
) -> asyncio.Task[_R]:
"""Create a task from within the eventloop.
@@ -754,7 +758,9 @@ class ConfigEntry:
target: target to call.
"""
task = hass.async_create_task(target)
task = hass.async_create_task(
target, f"{name} {self.title} {self.domain} {self.entry_id}"
)
self._tasks.add(task)
task.add_done_callback(self._tasks.remove)
@@ -824,7 +830,10 @@ class ConfigEntriesFlowManager(data_entry_flow.FlowManager):
init_done: asyncio.Future[None] = asyncio.Future()
self._pending_import_flows.setdefault(handler, {})[flow_id] = init_done
task = asyncio.create_task(self._async_init(flow_id, handler, context, data))
task = asyncio.create_task(
self._async_init(flow_id, handler, context, data),
name=f"config entry flow {handler} {flow_id}",
)
self._initialize_tasks.setdefault(handler, []).append(task)
try:
@@ -1112,7 +1121,8 @@ class ConfigEntries:
entry.domain,
context={"source": SOURCE_UNIGNORE},
data={"unique_id": entry.unique_id},
)
),
f"config entry unignore {entry.title} {entry.domain} {entry.unique_id}",
)
self._async_dispatch(ConfigEntryChange.REMOVED, entry)
@@ -1337,7 +1347,10 @@ class ConfigEntries:
for listener_ref in entry.update_listeners:
if (listener := listener_ref()) is not None:
self.hass.async_create_task(listener(self.hass, entry))
self.hass.async_create_task(
listener(self.hass, entry),
f"config entry update listener {entry.title} {entry.domain} {entry.domain}",
)
self._async_schedule_save()
self._async_dispatch(ConfigEntryChange.UPDATED, entry)
@@ -1367,7 +1380,10 @@ class ConfigEntries:
error_if_core=False,
)
for platform in platforms:
self.hass.async_create_task(self.async_forward_entry_setup(entry, platform))
self.hass.async_create_task(
self.async_forward_entry_setup(entry, platform),
f"config entry forward setup {entry.title} {entry.domain} {entry.entry_id} {platform}",
)
async def async_forward_entry_setups(
self, entry: ConfigEntry, platforms: Iterable[Platform | str]
@@ -1549,7 +1565,8 @@ class ConfigFlow(data_entry_flow.FlowHandler):
continue
if should_reload:
self.hass.async_create_task(
self.hass.config_entries.async_reload(entry.entry_id)
self.hass.config_entries.async_reload(entry.entry_id),
f"config entry reload {entry.title} {entry.domain} {entry.entry_id}",
)
raise data_entry_flow.AbortFlow(error)