innocuous-symmetry/cat-reddit
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

restored video function, app renders without crashing #16

Closed
innocuous-symmetry wants to merge 6 commits from restored-function into master
pull from: restored-function
merge into: innocuous-symmetry:master
Conversation 1 Commits 6 Files Changed 9 +14 -20
innocuous-symmetry commented 2022-02-23 22:15:12 +00:00 (Migrated from github.com)
Copy Link

This update dealt with an error that caused the app to crash on load in some cases. These cases were accounted for in VideoPlayer component. There are still some known issues with the video rendering process as it stands:

  • Some posts without a corresponding audio file will not pass the video source to the component.
  • Videos with an external source (especially from Youtube) are not yet accounted for.
  • The video player occasionally overflows from the post container in certain screen orientations.
This update dealt with an error that caused the app to crash on load in some cases. These cases were accounted for in VideoPlayer component. There are still some known issues with the video rendering process as it stands: - Some posts without a corresponding audio file will not pass the video source to the component. - Videos with an external source (especially from Youtube) are not yet accounted for. - The video player occasionally overflows from the post container in certain screen orientations.
netlify[bot] commented 2022-02-23 22:15:18 +00:00 (Migrated from github.com)
Copy Link

✔️ Deploy Preview for reddit-but-all-cats ready!

🔨 Explore the source changes: 47c55229e1

🔍 Inspect the deploy log: https://app.netlify.com/sites/reddit-but-all-cats/deploys/6216b25f9090b900083ab198

😎 Browse the preview: https://deploy-preview-16--reddit-but-all-cats.netlify.app/

✔️ Deploy Preview for *reddit-but-all-cats* ready! 🔨 Explore the source changes: 47c55229e1461c4150a963aa9ac7ae39db53ca86 🔍 Inspect the deploy log: [https://app.netlify.com/sites/reddit-but-all-cats/deploys/6216b25f9090b900083ab198](https://app.netlify.com/sites/reddit-but-all-cats/deploys/6216b25f9090b900083ab198) 😎 Browse the preview: [https://deploy-preview-16--reddit-but-all-cats.netlify.app/](https://deploy-preview-16--reddit-but-all-cats.netlify.app/)

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something isn't working
documentation
Improvements or additions to documentation
duplicate
This issue or pull request already exists
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
invalid
This doesn't seem right
question
Further information is requested
wontfix
This will not be worked on
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
innocuous-symmetry
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: innocuous-symmetry/cat-reddit#16
No description provided.
Delete Branch "restored-function"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?